Internally use libuv for mkdir on all platforms #33422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Sep 30, 2019
|
@vtnash (thanks for the review) do you have any thoughts on the error message that is throws? Currently we throw |
|
Yeah, we might want to think about merging those, but for now, you just need to change the test. |
|
anyone want to rekick windows ci? |
simonbyrne
added a commit
that referenced
this pull request
Jun 2, 2020
The error thrown by `mkdir` when the directory already exists was changed in #33422.
simonbyrne
added a commit
that referenced
this pull request
Jun 3, 2020
The error thrown by `mkdir` when the directory already exists was changed in #33422.
KristofferC
pushed a commit
that referenced
this pull request
Jun 4, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
The error thrown by `mkdir` when the directory already exists was changed in JuliaLang#33422.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.