Replace realpath implementation with libuv #33116
Conversation
| windowserror(:realpath, iszero(len)) | ||
| resize!(buf, len) # strips NUL terminator on last call | ||
| end | ||
| if 4 < len < 264 && 0x005c == buf[1] == buf[2] == buf[4] && 0x003f == buf[3] |
There was a problem hiding this comment.
I seem to recall that libuv is missing the length check, but otherwise lgtm
There was a problem hiding this comment.
You mean a max path type length check? I don't think I see that this is an issue.
There was a problem hiding this comment.
libuv doesn't check that len > 4, but since it uses wcsncmp (which stops at NUL chars) it should be fine there. It doesn't check len < 264 either, but I guess excluding actual paths with length > 263 that start with \\?\ is less of a practical concern?
There was a problem hiding this comment.
Paths that start with \\?\ are extended paths and can extend up to 32 767 characters. So the len < 264 check should actually not occur.
|
|
|
filewatching failure on win32 and another fluke on freebsd |
|
merge? |
(cherry picked from commit 921b4f8)
5 participants
fixes #32597 fixes #32298 fixes #33127