docs: prepend v to tag string #32993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, this should also be backported to 1.2, together with #32823. That is to make sure that automatic docs deployment works for 1.2 bugfix releases. |
staticfloat
approved these changes
Aug 20, 2019
Member
|
I don't think we deploy docs from the buildbot on 1.2, do we? Should not be needed to backport this to 1.2 in that case. |
Member
|
Or I guess we have turned off Travis completely (e.g. even for |
Member
|
Yeah, doesn't hurt to keep our automation high. |
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2019
(cherry picked from commit 6723492)
36 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
(cherry picked from commit 6723492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that
TRAVIS_TAGis e.g.v1.3.0and not just1.3.0. It would be good to backport this to 1.3 too. cc @staticfloat