-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Disallow var syntax in string interpolation #32948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The var"##" syntax should be disabled in string interpolation.
1994e77 to
2ca4b31
Compare
|
Right I've sorted those problems out! I also added a workaround to preserve the behavior of I think we should change the way |
9e01f42 to
941a6a9
Compare
This is special cased for compatibility. A more general fix would be to make cmd interpolation syntax exactly the same as string interpolation.
941a6a9 to
9cc2f44
Compare
|
CI errors look unrelated (win64 — temp files; freebsd — an internal build slave error). |
|
@JeffBezanson can you live with the ugly |
|
This bug breaks both Juno and the CUDA stack, so it'd be great to get the fix in quickly. |
|
bump |
The var"##" syntax should be disabled in string interpolation. Disallow `var` syntax in command interpolations This is special cased for compatibility. A more general fix would be to make cmd interpolation syntax exactly the same as string interpolation. (cherry picked from commit 050160c)
The
var"##"syntax should be disabled in string interpolation.Also work around a subtle problem with command interpolation's use of Meta.parse in non-greedy mode, combined with the new
varsyntax which would causeBase.shell_parse("\"(\$var)\"")to miss the trailing)character.This is a quick fix for a bit of fallout from #32408 which affects PyCall's build script, among other things.
Fixes #32951