Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use specsig for all-singleton-type signatures (or 0 arguments) #32821

Merged
merged 1 commit into from
Aug 11, 2019
Merged

use specsig for all-singleton-type signatures (or 0 arguments) #32821

merged 1 commit into from
Aug 11, 2019

Conversation

JeffBezanson
Copy link
Member

This seems worth doing. Impact on sysimg is negligible.
Before:

-rwxrwxr-x 1 jeff jeff 140770600 Aug  6 21:04 sys.so

after:

-rwxrwxr-x 1 jeff jeff 140771720 Aug  6 21:23 sys.so

@JeffBezanson JeffBezanson added the compiler:codegen Generation of LLVM IR and native code label Aug 7, 2019
Keno
Keno approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@JeffBezanson JeffBezanson merged commit 987a3d6 into master Aug 11, 2019
@JeffBezanson JeffBezanson deleted the jb/specsig0 branch August 11, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @Keno