Prevent download on windows picking up rogue curl executable #32412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
changed the title
Contributor
Author
|
Looks like this fixes things although I wonder where it's finding that extra curl executable from |
vtjnash
approved these changes
Jun 26, 2019
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
(of the first commit, anyhow)
Contributor
Author
|
I see what's happening: The download function ends up picking up |
Contributor
Author
|
I think cygwin needs to be updated on the build bots. Testing locally, the curl version provided by cygwin works fine |
KristofferC
pushed a commit
that referenced
this pull request
Jul 1, 2019
(cherry picked from commit 6e6bd8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if this is the cause of recent failures on buildbots