Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent download on windows picking up rogue curl executable #32412

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Prevent download on windows picking up rogue curl executable #32412

merged 3 commits into from
Jun 28, 2019

Conversation

musm
Copy link
Contributor

@musm musm commented Jun 25, 2019

Checking if this is the cause of recent failures on buildbots

@musm musm mentioned this pull request Jun 25, 2019
Merged
32 tasks
@musm musm changed the title Test download function picking up rouge curl Prevent download on windows picking up rogue curl executable Jun 26, 2019
@musm
Copy link
Contributor Author

musm commented Jun 26, 2019

Looks like this fixes things although I wonder where it's finding that extra curl executable from

vtjnash
vtjnash approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(of the first commit, anyhow)

@musm
Copy link
Contributor Author

musm commented Jun 26, 2019 •
edited
Loading

I see what's happening: The download function ends up picking up C:\\cygwin\\bin\\curl.exe
and for some reason this leads to the weird escaping?

@ChiaffarelliMarco ChiaffarelliMarco mentioned this pull request Jun 27, 2019
Merged
@musm
Copy link
Contributor Author

musm commented Jun 27, 2019

I think cygwin needs to be updated on the build bots.

Testing locally, the curl version provided by cygwin works fine

@vtjnash vtjnash merged commit 6e6bd8e into JuliaLang:master Jun 28, 2019
@vtjnash vtjnash mentioned this pull request Jun 28, 2019
Merged
KristofferC pushed a commit that referenced this pull request Jul 1, 2019
@musm @KristofferC
Prevent download on windows picking up a rogue curl executable (#32412)
525d4e9 
(cherry picked from commit 6e6bd8e)
@sostock sostock mentioned this pull request Jul 1, 2019
Merged
@musm musm deleted the patch-6 branch July 3, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@musm @vtjnash @KristofferC @ararslan