Skip to content

[release-1.2] types: per comment, avoid copy when t is not bound (#32176) #32355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

[release-1.2] types: per comment, avoid copy when t is not bound (#32176) #32355

merged 1 commit into from
Jun 19, 2019

Conversation

@JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Jun 18, 2019

Backports #32176 to release-1.2.

@vtjnash @JeffBezanson
types: per comment, avoid copy when t is not bound (#32176)
215a8e9 
As mentioned in #9378.
Fix recursion issue mentioned in #25796 by using inst_datatype_inner
instead of inst_datatype, so that we shouldn't be making copies of
any non-bound objects (anything maybe-cacheable) now.
(cherry picked from commit 217507f)
@JeffBezanson JeffBezanson added this to the 1.2 milestone Jun 18, 2019
@JeffBezanson JeffBezanson changed the title types: per comment, avoid copy when t is not bound (#32176) [release-1.2] types: per comment, avoid copy when t is not bound (#32176) Jun 18, 2019
@KristofferC
Copy link
Member

KristofferC commented Jun 18, 2019

Should we perhaps backport this into the backport branch (backports-1.2.0-rc2) to make it easier to run a PkgEval + Nanosoldier on all new changes and then we merge it into the actual release branch?

@JeffBezanson
Copy link
Member Author

JeffBezanson commented Jun 18, 2019

Yes, feel free to move this and my other 1.2 PR to the backports branch.

@KristofferC KristofferC changed the base branch from release-1.2 to backports-1.2.0-rc2 June 19, 2019 13:35
@KristofferC KristofferC merged commit 5579bc6 into backports-1.2.0-rc2 Jun 19, 2019
@KristofferC KristofferC deleted the jb/fix32216 branch June 19, 2019 13:36
@fredrikekre fredrikekre mentioned this pull request Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JeffBezanson @KristofferC @vtjnash