Be gentler in setting BinaryBuilder makevars #32044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many users have expressed the frustration that setting `USE_BINARYBUILDER=0` in `Make.user` doesn't take; this is because the initializations here should have been `?=` (e.g. "set unless already set") instead of `:=` (e.g. "set immediately"). This remedies that.
vchuravy
reviewed
May 16, 2019
Co-Authored-By: Valentin Churavy <vchuravy@users.noreply.github.com>
vchuravy
approved these changes
May 16, 2019
Keno
reviewed
May 16, 2019
| $(foreach proj,$(BB_PROJECTS),$(if $(USE_BINARYBUILDER_$(proj)),,$(eval USE_BINARYBUILDER_$(proj) ?= $(USE_BINARYBUILDER)))) | ||
|
|
||
| # Use the Assertions build | ||
| BINARYBUILDER_LLVM_ASSERTS := 0 |
Member
There was a problem hiding this comment.
Unrelated, but shouldn't this just look at the LLVM_ASSERTIONS variable?
Member
Author
There was a problem hiding this comment.
Probably? @vchuravy is that just a silly oversight on my part?
Member
There was a problem hiding this comment.
I originally had it split out to make switching more explicit. No strong feelings on my part.
We don't actually have an asserts build to download (yet)
Member
|
I've thought this would be good to change for a long time. Would also be good to change any other variables that can be set in Make.user to configure the build process so that |
Member
Author
|
Will address the LLVM_ASSETS stuff in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users have expressed the frustration that setting
USE_BINARYBUILDER=0inMake.userdoesn't take; this is because the initializations here should have been?=(e.g. "set unless already set") instead of:=(e.g. "set immediately"). This remedies that.