bugfix in Hermitian + complex*I #32001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
linear algebra
Member
Author
|
Travis OSX failure is unrelated |
ararslan
reviewed
May 13, 2019
ararslan
reviewed
May 13, 2019
andreasnoack
approved these changes
May 13, 2019
KristofferC
pushed a commit
that referenced
this pull request
May 20, 2019
(cherry picked from commit b05c0c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug noted in 49023b5#r33494573 (#29500) where a complex
Hermitianmatrix pluscomplex*Iwould give an incorrect result (complex-symmetric rather than conjugating the lower triangle).Update:
Also reduces the problematic reliance onNevermind, this is tricky and should be left for another PR.Base._return_typefor non-empty matrices in this code.