fix part of #30901, more consistent printing of Day
#31962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
needs decision
ararslan
approved these changes
May 8, 2019
|
I'm not sure it's really a good solution, since it changes even more the printing of |
|
Triage is in favor of reverting those on the release branch. Master can stay as-is so we can try to develop this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints as e.g.
Day(1)for allshowandreprcalls.1 dayis used forprintor mimetype text/plain.For this issue in the 1.2 timeframe, I think we should either do this or nothing. The only way to get a more significant improvement is to add another IOContext flag so we can be smarter about when to print in julia syntax.
Fixes part of #30901.