Improve IO read performance. #31814
Merged
Improve IO read performance. #31814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually extract out a separate noinline _throw_not_readable function. Addresses JuliaLang#28481 (comment). Benchmark scenario: ```julia using BenchmarkTools, Random const N = 1000 @Btime read(buf, Float64) evals = N setup = begin rng = MersenneTwister(1) writebuf = IOBuffer() map(1 : N) do _ write(writebuf, rand(rng, Float64)) end buf = IOBuffer(take!(writebuf)) end ``` Benchmark results (CPU: Intel(R) Core(TM) i7-6950X CPU @ 3.00GHz): * Before: 2.533 ns (0 allocations: 0 bytes) * After: 1.775 ns (0 allocations: 0 bytes) Performance is now much closer to, but still not quite at the level of FastIOBuffers.FastReadBuffer (1.555 ns (0 allocations: 0 bytes)).
Closed
JeffBezanson
added
io
vtjnash
approved these changes
Apr 24, 2019
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
It’s probably good to consolidate all these too
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2019
Manually extract out a separate noinline _throw_not_readable function. Addresses #28481 (comment). (cherry picked from commit 98b34fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually extract out a separate noinline _throw_not_readable function.
Addresses #28481 (comment).
Benchmark scenario:
Benchmark results (CPU: Intel(R) Core(TM) i7-6950X CPU @ 3.00GHz):
Performance is now much closer to, but still not quite at the level of
FastIOBuffers.FastReadBuffer(1.555 ns (0 allocations: 0 bytes)).