-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try weaning ourselves completely off of staticfloat/julia*
Homebrew taps
#30991
Conversation
We also have a SuiteSparseBuilder. Time to move to using it: And also openlibmbuilder? |
|
Yeah, it's a problem with the SuiteSparse build step. I'm taking Viral's suggestion and getting BB-built SuiteSparse ready for primetime. |
@andreasnoack @ViralBShah As part of integrating BB-installed SuiteSparse I have attempted to reduce differences between the BB installation script and this one. The two big ones are:
Please let me know if I've done anything wrong that will screw up the sparse landscape. |
Seems like this is updating suitesparse - which is good. I don't expect there are any breaking API changes. For list of subprojects, it seems we are doing the following: I believe we do not have bindings for KLU, LDL or RBio. @andreasnoack Do you know if we can safely ignore those and not build them? |
c0c9dcf
to
6dd9ec2
Compare
Do we want to disable OpenMP? We do so on Windows in BB-land, and the OpenMP flag is causing a problem on the FreeBSD CI bot (where I assume OpenMP is just not installed; it is installed on BB). I remember back in the mists of time we disabled OpenMP because we wanted a different way of controlling parallelism, but I'm not sure if that is purposeful or not. Unless I hear otherwise, I am going to disable OpenMP in the from-source builds here just so that we can get CI passing again. Note that while we have BB tarballs available for all platforms, we're only really using it on Travis OSX and Appveyor, presumably because we want to continue testing building from source on some of the platforms. |
Okay, shortlist of changes within this branch:
If this passes CI and the build changes are acceptable to the Sparsity Shifu's, let's merge it. |
Co-Authored-By: staticfloat <staticfloat@gmail.com>
Looks like this is good to go; the 32-bit windows build timed out, but I'm trying it again. |
staticfloat/julia*
Homebrew tapsstaticfloat/julia*
Homebrew taps
🎉 |
This is a shot at fixing #30949. Note that this will cause us to start building SuiteSparse again, but that's not that bad; SS builds pretty quickly. The most important two are LLVM and OpenBLAS, which are both covered by BB at this point, so we don't need to use my outdated tap anymore.