default to /usr/bin/curl on macOS #30969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
approved these changes
Feb 5, 2019
|
It should not be user-visible for people with working Julia installations, so that would argue against NEWS. |
|
I guess we want the mac tests to run, but the mac ci is broken. Looks good. We probably want a backport on this to 1.0 and 1.1. |
StefanKarpinski
approved these changes
Feb 7, 2019
|
I do not think this is backport appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30956.
We don't even document how
download()decides what program to use, we want to default to a workingdownloadcommand if at all possible, and generally on macOS people don't expect that installing e.g. homebrew or anaconda will affect how "unrelated" programs like Julia work.