some improvements to static parameter handling in inference #30878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/sptypes
branch
4 times, most recently
from
8173306 to
d80f6e8
Compare
This is more consistent with how other variables and arguments are treated, and more general.
JeffBezanson
force-pushed
the
jb/sptypes
branch
from
d80f6e8 to
36d490a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just a refactoring to store static parameters as lattice elements instead of their (hopefully constant) values.
The second commit improves type information for static parameters that come from
::Type{T}, where we didn't know thatTmust be a Type. This is very useful for functions likezerosthat sometimes take a type argument. Motivated by wanting to get better type info from examining fewer methods.