Treat zero-dimensional views as contiguous SubArrays #29895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfsch
commented
Nov 1, 2018
| @@ -46,7 +46,7 @@ check_parent_index_match(parent, ::NTuple{N, Bool}) where {N} = | |||
| throw(BoundsError(T(parent, indices, offset1, stride1), I)) | |||
|
|
|||
| # This computes the linear indexing compatibility for a given tuple of indices | |||
| viewindexing() = IndexLinear() | |||
There was a problem hiding this comment.
The function viewindexing() is never called without an argument in Base, so I assume this line was meant as the fallback case for viewindexing(tail(I)). Changing the argument to an empty tuple provides the correct linear indexing if all indices are ScalarIndex.
timholy
approved these changes
Nov 2, 2018
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that zero-dimensional SubArrays (views of a single value) are indexed with
IndexLinearand are a subtype ofFastContiguousSubArray. This way,iscontiguousreturnstruefor such a view.The rationale for this is that
iscontiguouscan be used to decide whether a SubArray can be passed to a C function, as is done in the package MPI.jl. With the proposed changes, single values of an array can be sent and received with MPI by passing a zero-dimensional view to the MPI functions.Fixes #29608