Skip to content

Add Float16-Int comparisons #29870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Add Float16-Int comparisons #29870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
579e472
Add comparisons for Float16
Oct 31, 2018
c3de7ac
Add comparisons for Float16
Oct 31, 2018
e75c476
Add Float16 comparisons
Nov 2, 2018
f6aa799
Add Float16 comparisons
Nov 2, 2018
d44a0b2
Add tests
Nov 3, 2018
32d298d
base: make diff() use views and broadcasting
stev47 Oct 27, 2018
0b239f6
Add NEWS
mbauman Oct 30, 2018
2a0c4c1
Add comparisons for Float16
Oct 31, 2018
e13fac6
Add comparisons + tests for Float16
Oct 31, 2018
be6d4ef
float16-int-comparison
Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions base/float.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,15 +501,41 @@ for Ti in (Int64,UInt64,Int128,UInt128)
end
end
end
==(x::Float16, y::Union{Int128,UInt128}) = Float64(x)==Float64(y)
==(x::Union{Int128,UInt128}, y::Float16) = Float64(x)==Float64(y)

==(x::Float32, y::Union{Int32,UInt32}) = Float64(x)==Float64(y)
==(x::Union{Int32,UInt32}, y::Float32) = Float64(x)==Float64(y)
<(x::Float16, y::Union{Int128,UInt128}) = Float64(x)<Float64(y)
<(x::Union{Int128,UInt128}, y::Float16) = Float64(x)<Float64(y)

<(x::Float32, y::Union{Int32,UInt32}) = Float64(x)<Float64(y)
<(x::Union{Int32,UInt32}, y::Float32) = Float64(x)<Float64(y)
<=(x::Float16, y::Union{Int128,UInt128}) = Float64(x)<=Float64(y)
<=(x::Union{Int128,UInt128}, y::Float16) = Float64(x)<=Float64(y)

<=(x::Float32, y::Union{Int32,UInt32}) = Float64(x)<=Float64(y)
<=(x::Union{Int32,UInt32}, y::Float32) = Float64(x)<=Float64(y)
==(x::Float16, y::Union{Int64,UInt64}) = Float64(x)==Float64(y)
==(x::Union{Int64,UInt64}, y::Float16) = Float64(x)==Float64(y)

<(x::Float16, y::Union{Int64,UInt64}) = Float64(x)<Float64(y)
<(x::Union{Int64,UInt64}, y::Float16) = Float64(x)<Float64(y)

<=(x::Float16, y::Union{Int64,UInt64}) = Float64(x)<=Float64(y)
<=(x::Union{Int64,UInt64}, y::Float16) = Float64(x)<=Float64(y)

==(x::Float16, y::Union{Int16,UInt16}) = Float32(x)==Float32(y)
==(x::Union{Int16,UInt16}, y::Float16) = Float32(x)==Float32(y)

<(x::Float16, y::Union{Int16,UInt16}) = Float32(x)<Float32(y)
<(x::Union{Int16,UInt16}, y::Float16) = Float32(x)<Float32(y)

<=(x::Float16, y::Union{Int16,UInt16}) = Float32(x)<=Float32(y)
<=(x::Union{Int16,UInt16}, y::Float16) = Float32(x)<=Float32(y)

==(x::Union{Float16,Float32}, y::Union{Int32,UInt32}) = Float64(x)==Float64(y)
==(x::Union{Int32,UInt32}, y::Union{Float16,Float32}) = Float64(x)==Float64(y)

<(x::Union{Float16,Float32}, y::Union{Int32,UInt32}) = Float64(x)<Float64(y)
<(x::Union{Int32,UInt32}, y::Union{Float16,Float32}) = Float64(x)<Float64(y)

<=(x::Union{Float16,Float32}, y::Union{Int32,UInt32}) = Float64(x)<=Float64(y)
<=(x::Union{Int32,UInt32}, y::Union{Float16,Float32}) = Float64(x)<=Float64(y)


abs(x::Float16) = reinterpret(Float16, reinterpret(UInt16, x) & 0x7fff)
Expand Down
10 changes: 10 additions & 0 deletions test/numbers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,16 @@ end
@test Float64(UInt128(3.7e19)) == 3.7e19
@test Float64(UInt128(3.7e30)) == 3.7e30
end
@testset "Float16 vs Int comparisons" begin
@test !(Inf16 == typemax(Int16))
@test !(Inf16 == typemax(Int32))
@test !(Inf16 == typemax(Int64))
@test !(Inf16 == typemax(Int128))
@test !(Inf16 == typemax(UInt16))
@test !(Inf16 == typemax(UInt32))
@test !(Inf16 == typemax(UInt64))
@test !(Inf16 == typemax(UInt128))
end
@testset "NaN comparisons" begin
@test !(NaN <= 1)
@test !(NaN >= 1)
Expand Down