Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libunwind version check with patch releases #29082

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Conversation

nalimilan
Copy link
Member

libunwind patch releases like 1.2.1 have UNW_VERSION_MINOR = 2.1, which
makes the comparison fail. Use a more robust comparison which excludes
all versions between 1.0 and 1.2 instead.
https://savannah.nongnu.org/bugs/index.php?52529

Fixes #23615, #24802.

libunwind patch releases like 1.2.1 have UNW_VERSION_MINOR = 2.1, which
makes the comparison fail. Use a more robust comparison which excludes
all versions between 1.0 and 1.2 instead.
https://savannah.nongnu.org/bugs/index.php?52529
@nalimilan nalimilan added the building Build system, or building Julia or its dependencies label Sep 7, 2018
@JeffBezanson JeffBezanson merged commit 3b428c9 into master Sep 10, 2018
@JeffBezanson JeffBezanson deleted the nl/libunwind branch September 10, 2018 19:07
@eli-schwartz
Copy link
Contributor

$ cat /tmp/floating-math.h
#if (2.1 != 0 && 2.1 != 1)
#endif
$ cpp /tmp/floating-math.h 
# 1 "/tmp/floating-math.h"
# 1 "<built-in>"
# 1 "<command-line>"
# 31 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 32 "<command-line>" 2
# 1 "/tmp/floating-math.h"
/tmp/floating-math.h:1:6: error: floating constant in preprocessor expression
 #if (2.1 != 0 && 2.1 != 1)
      ^~~
/tmp/floating-math.h:1:18: error: floating constant in preprocessor expression
 #if (2.1 != 0 && 2.1 != 1)
                  ^~~

@nalimilan
Copy link
Member Author

Damn, so even this isn't enough to fix the comparison issue... Then I don't know what we can do except for fixing libunwind upstream. :-(

@yuyichao
Copy link
Contributor

It is fixed upstream...

@nalimilan
Copy link
Member Author

Ah, good to know, that's indeed libunwind/libunwind#30. Too bad there hasn't been any release since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants