Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dispatch of SparseMatrixCSC*Diagonal multiplication #29045

Merged
merged 4 commits into from
Sep 5, 2018
Merged

Fix dispatch of SparseMatrixCSC*Diagonal multiplication #29045

merged 4 commits into from
Sep 5, 2018

Commits on Sep 4, 2018

  1. Fix type signature of mul! methods for multiplying SparseMatrixCSCs w… 

    …ith Diagonal matrices. Type signature for diagonal matrices was wrong, causing fallback to generic Matmul.
    @Pbellive
    Pbellive committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    52fa288 View commit details
    Browse the repository at this point in the history

  2. Add SparseMatrixCSC*Diagonal dispatch test

    @Pbellive
    Pbellive committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    61af5c1 View commit details
    Browse the repository at this point in the history

  3. Fix trailing whitespace

    @Pbellive
    Pbellive committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    13105cd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Don't copy with deepcopy

    @andreasnoack
    andreasnoack authored Sep 5, 2018
    Configuration menu
    Copy the full SHA
    1fe0e11 View commit details
    Browse the repository at this point in the history