Skip to content

Avoid including sys-debug.so and libjulia-debug.so in the binary-dist. #27814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

Avoid including sys-debug.so and libjulia-debug.so in the binary-dist. #27814

merged 1 commit into from
Jun 30, 2018

Conversation

ViralBShah
Copy link
Member

Fixes #27753

nalimilan
nalimilan reviewed Jun 27, 2018
View reviewed changes
Makefile Outdated
@@ -357,7 +358,7 @@ endif
cp -R -L $(build_includedir)/julia/* $(DESTDIR)$(includedir)/julia
# Copy system image
$(INSTALL_M) $(build_private_libdir)/sys.$(SHLIB_EXT) $(DESTDIR)$(private_libdir)
$(INSTALL_M) $(build_private_libdir)/sys-debug.$(SHLIB_EXT) $(DESTDIR)$(private_libdir)
# $(INSTALL_M) $(build_private_libdir)/sys-debug.$(SHLIB_EXT) $(DESTDIR)$(private_libdir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird to keep this but commented out. Better check whether julia-debug appears in JL_LIBS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea.

@ViralBShah
Copy link
Member Author

One thing we can do is provide the debug libraries as an add-on in a separate download, rather than in the default.

@ViralBShah ViralBShah force-pushed the vs/nodbg branch 2 times, most recently from 031c0dc to 94276ca Compare June 28, 2018 03:31
@ViralBShah
Copy link
Member Author

The .dSYM files on Mac are an additional 140M (on disk after installation).

@ViralBShah ViralBShah added the triage This should be discussed on a triage call label Jun 28, 2018
@ViralBShah
Copy link
Member Author

Triage should discuss whether we can go ahead with this.

@ViralBShah
Copy link
Member Author

ViralBShah commented Jun 28, 2018 •
edited
Loading

For the separate download, considerable more work will be need to package these things up into installers, and adjust all the various bots and infrastructure. I propose not shipping these in the default binaries, and working on the addon package later on if there is a real need for it.

@StefanKarpinski
Copy link
Member

As far as I'm aware, we've never gotten a bug report based on the bundled debug version.

@ararslan ararslan added the building Build system, or building Julia or its dependencies label Jun 28, 2018
@ViralBShah
Copy link
Member Author

It seems that the mac binaries created here do not work. Am I removing a step that is crucial for working binaries? I can't quite tell.

The command "/tmp/julia/bin/julia --sysimage-native-code=no -e 'true' && /tmp/julia/bin/julia-debug --sysimage-native-code=no -e 'true'" exited with 133.
0.03s$ /tmp/julia/bin/julia -e 'Base.require(Main, :InteractiveUtils).versioninfo()'
dyld: Library not loaded: @rpath/libjulia.dylib
  Referenced from: /tmp/julia/bin/julia
  Reason: image not found
/Users/travis/.travis/job_stages: line 78: 56622 Trace/BPT trap: 5       /tmp/julia/bin/julia -e 'Base.require(Main, :InteractiveUtils).versioninfo()'

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Jun 28, 2018 •
edited
Loading

Triage agrees: remove it.

@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Jun 28, 2018
@ViralBShah
Copy link
Member Author

The mac issue is fixed. If we get a green from CI, we can merge this.

@ViralBShah
Copy link
Member Author

ViralBShah commented Jun 29, 2018 •
edited
Loading

mac is failing on cmdlineargs. Turns out it needs the .dSYM libraries.

linux32 failed because it could not download the certificates (connection error) - so shouldn't be an issue.

@nalimilan nalimilan mentioned this pull request Jun 30, 2018
Closed
@ViralBShah
Introduce BUNDLE_DEBUG_LIBS to control whether debug libs are included
c0ef7ec 
in the binaries.
By default, avoid including sys-debug.so and libjulia-debug.so
in the binary-dist phase.
Don't test julia-debug in CI, since we do not install it.
@ViralBShah ViralBShah merged commit b70dc52 into master Jun 30, 2018
@ViralBShah ViralBShah deleted the vs/nodbg branch June 30, 2018 20:01
nalimilan pushed a commit that referenced this pull request Jul 5, 2018
@ViralBShah @nalimilan
Introduce BUNDLE_DEBUG_LIBS to control whether debug libs are include…
45981d2 
…d in the binaries (#27814)

By default, avoid including sys-debug.so and libjulia-debug.so in the generated binaries.
Don't test julia-debug in CI, since we do not install it.
@musm musm mentioned this pull request Nov 13, 2018
Closed
@staticfloat staticfloat mentioned this pull request Nov 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViralBShah @StefanKarpinski @nalimilan @ararslan