Fix fixup-libgfortran
#27667
Merged
Fix fixup-libgfortran
#27667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/fixup_fixup_libgfortran
branch
2 times, most recently
from
e03a8d3
to
48939cc
Compare
|
Confirmed working on the buildbots, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally broke
fixup-libgfortranby only telling it to look atliblapack.soto get its hints about wherelibgfortranlives. However,liblapack.sodoesn't exist most of the time, it's just calledlibopenblas64_.so. This PR causesfixup-libgfortranto look around a bit harder to find these sneaky little runtime libraries so that we can pull them in to our libdir duringmake binary-dist.