hack to avoid perm error when rm:ing temp dir on windows #26879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Apr 22, 2018
stdlib/Pkg/test/pkg.jl
Outdated
| @@ -40,7 +40,10 @@ function temp_pkg_dir(fn::Function, tmp_dir=joinpath(tempdir(), randstring()), | |||
| end | |||
| fn() | |||
| finally | |||
| remove_tmp_dir && rm(tmp_dir, recursive=true) | |||
| if remove_tmp_dir | |||
| Sys.iswindows() && gc() # to make sure handles are closed on Windows | |||
There was a problem hiding this comment.
Should be GC.gc() now, which is why the AV build is failing here
StefanKarpinski
force-pushed
the
sk/windows-rmdir-workaround
branch
from
f75d54c
to
3ab845e
Compare
|
This rm is not the problem, #26883 should hopefully fix it. Otherwise I revert the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the failure seen here: https://ci.appveyor.com/project/JuliaLang/julia/build/1.0.26225/job/vtwv10ff4l8n7i2e, see #26854.