loading: a bug fix, complete tests, delete old/redundant tests #26260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the testing and adds tests for `locate_package` in addition to `identify_package`. In order for these tests to pass, `locate_package` had to be fixed so that it can fine the entry point file for a project that is in the load path.
StefanKarpinski
force-pushed
the
sk/loadtests
branch
from
146c5dc to
ec75c58
Compare
|
@JeffBezanson: can you verify that the AV failure here is the one that #26257 is meant to fix? In that case does it make sense to merge this now since the failure is pre-existing, unrelated to this change, and will be fixed elsewhere? |
|
Nevermind, I convinced myself that it is the same (same error, same backtrace), so imma merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.