Ensure that all isequal methods return Bool to fix inference #26184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the return type of isequal() would be inferred as Union{Bool,Missing}
when the type of the argument is inferred as Any.
nalimilan
added
compiler:inference
| @@ -69,6 +69,8 @@ end | |||
| @test !isless(missing, missing) | |||
| @test !isless(missing, 1) | |||
| @test isless(1, missing) | |||
|
|
|||
| @test !any(T -> T === Union{Missing,Bool}, Base.return_types(isequal, Tuple{Any,Any})) | |||
There was a problem hiding this comment.
That doesn't work since there are several Any values in that list (not sure why).
|
Bump. |
JeffBezanson
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the return type of
isequalwould be inferred asUnion{Bool,Missing}when the type of the argument is inferred asAny.