Attach backtraces explicitly in error logging #25569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid ambiguity and confusion, do not assume that `catch_backtrace()` is the backtrace associated with a logged exception. Instead, always attach the backtrace explicitly.
vtjnash
approved these changes
Jan 16, 2018
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
Attach backtraces explicitly in error logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid ambiguity and confusion, do not assume that
catch_backtrace()is the backtrace associated with a logged exception. Instead, always
attach the backtrace explicitly.
I think this is the best way to address @JeffBezanson's comment at #25370 (comment). I believe #19979 can be fixed, but that won't address the potential for ambiguity in not attaching the backtrace explicitly. I'm not thrilled about the extra boilerplate, but it might be best for now.