Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strides and stride deprecation to NEWS #25510

Merged
merged 4 commits into from
Jan 13, 2018

Conversation

dlfivefifty
Copy link
Contributor

This updates NEWS for the added strides and stride deprecation from pull request

#25321

as requested by @timholy.

dlfivefifty and others added 4 commits January 11, 2018 17:57
The methods themselves are still used and called, we just no longer provide a default implementation for all `AbstractArrays`
@mbauman
Copy link
Member

mbauman commented Jan 12, 2018

Thanks @dlfivefifty! I pushed a proposed change — feel free to edit/reject/counter if you don't like it. I think it'd be nice to clarify that the interface is still the same, it's just the generic implementation that is deprecated.

@mbauman mbauman merged commit caccf13 into JuliaLang:master Jan 13, 2018
@@ -937,6 +937,10 @@ Deprecated or removed

* `findin(a, b)` has been deprecated in favor of `find(occursin(b), a)` ([#24673]).

* The generic implementations of `strides(::AbstractArray)` and `stride(::AbstractArray, ::Int)`
have been deprecated. Subtypes of `AbstractArray` that implement the newly introduced strided
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

mbauman added a commit that referenced this pull request Jan 14, 2018
Fixes indentation mistake introduced in #25510 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants