Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some small fixes to jl_log #25335

Merged
merged 1 commit into from
Dec 31, 2017
Merged

some small fixes to jl_log #25335

merged 1 commit into from
Dec 31, 2017

Conversation

JeffBezanson
Copy link
Member

  • synchronize printing format of fallback logging
  • make new logging work under --lisp

Also rename logmsg_thunk to logmsg_shim. I'd say it's more of a shim than a thunk :)

@JeffBezanson
some small fixes to jl_log
fd17e6e 
- synchronize printing format of fallback logging
- make new logging work under `--lisp`
@JeffBezanson JeffBezanson added the logging The logging framework label Dec 30, 2017
@JeffBezanson JeffBezanson merged commit 56b59ec into master Dec 31, 2017
@JeffBezanson JeffBezanson deleted the jb/fallback_log branch December 31, 2017 02:56
@c42f
Copy link
Member

c42f commented Jan 2, 2018

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
logging The logging framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @c42f