remove legacy at-pure annotation from linalg/adjtrans #25272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
bugfix
|
Haha, I just did this one too and was about to make a PR. I think this one should be removed as well: https://github.com/JuliaLang/julia/blob/master/base/linalg/rowvector.jl#L62 |
Yes, that instance was the original of which the instance in linalg/adjtrans.jl is a copy :). Happily no need to remove the original, though, due to #25217. Best! |
fredrikekre
approved these changes
Dec 26, 2017
|
@nanosoldier |
2 similar comments
|
@nanosoldier |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the problematic legacy
@pureannotation from linalg/adjtrans.jl. This branch passes the linalg, sparse, stdlib/IterativeEigensolvers, and stdlib/SuiteSparse test suites locally, so hopefully CI will also approve. Resolves #25242 (no longer segfaults) and #25271 (also no longer segfaults). Also ref. #25268 (comment) and #25265 (comment). Best! :)