Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workspace #25046

Merged
merged 1 commit into from
Dec 13, 2017
Merged

remove workspace #25046

merged 1 commit into from
Dec 13, 2017

Conversation

fredrikekre
Copy link
Member

close #10351, close #22434

NEWS.md Outdated
@@ -732,6 +732,8 @@ Deprecated or removed
* `trues(A::AbstractArray)` and `falses(A::AbstractArray)` are deprecated in favor of
`trues(size(A))` and `falses(size(A))` respectively ([#24595]).

* `workspace` is discontinued ([#25046]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link to Revise?

@@ -732,6 +732,9 @@ Deprecated or removed
* `trues(A::AbstractArray)` and `falses(A::AbstractArray)` are deprecated in favor of
`trues(size(A))` and `falses(size(A))` respectively ([#24595]).

* `workspace` is discontinued, check out [Revise.jl](https://github.com/timholy/Revise.jl)
for an alternative workflow ([#25046]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 Revise.jl still doesn't work on FreeBSD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue filed.
timholy/Revise.jl#66

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanKarpinski shouldn't this needed a deprecation warning too, not just deleting it?

Else people will just get an UndefVarError, with no idea that they should be checking out Revise.

@fredrikekre fredrikekre added the triage This should be discussed on a triage call label Dec 13, 2017
@StefanKarpinski StefanKarpinski merged commit 18e6dc1 into JuliaLang:master Dec 13, 2017
@fredrikekre fredrikekre deleted the fe/workspace branch December 13, 2017 16:01
@fredrikekre fredrikekre removed the triage This should be discussed on a triage call label Dec 13, 2017
@StefanKarpinski StefanKarpinski mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants