[release-0.6] Backport "Explicitly add -lpthread when building curl"
#24975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary on older Linuces (such as Ubuntu 12.04 x86) that have older OpenSSL library versions. Curl switched over to a threaded DNS resolver by default in version 7.55, and this requires `libpthread`. However, their build system relies on the fact that OpenSSL (usually) provides the proper linkage flags, and so breaks on older Linuces. See [0] for more details. [0] https://curl.haxx.se/mail/lib-2017-09/0112.html (cherry picked from commit c323437, PR #24261)
staticfloat
approved these changes
Dec 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #24261 to the release-0.6 branch. I observed a pthread-related failure when building curl on release-0.6 on the buildbots, so I figured this patch might be necessary.