remove unused temporary variables in code_warntype #23735
Conversation
KristofferC
force-pushed
the
kc/sort_opt_out
branch
from
040fcbd to
bbe5d3d
Compare
yuyichao
left a comment
yuyichao
left a comment
There was a problem hiding this comment.
I didn't suggest this originally since the full list provides information about the slot number (mainly useful for connecting code_warntype output to the jl_ output of the expressions in the debugger). There are less straight forward ways to obtain this information so while I prefer keeping it or at least making slot numbers inferable from code_warntype output I'm kind of ok with removing these.....
| else | ||
| print(emph_io, " <optimized out>") | ||
| print(emph_io, '\n') | ||
| elseif !('#' in slotnames[i] || '@' in slotnames[i]) |
There was a problem hiding this comment.
Note that slot names won't have automatically generated @ in them.
|
If this is needed for some low-level debugging there could be e.g. a flag that enables printing these again. I just don't think that printing them by default is necessary since they are likely of little value to most people who just want to check the type stability of their code. |
|
I think this one would be nice to have on 0.6. @ararslan |
|
I'm not sure that this is backport eligible since it's technically a feature rather than a bugfix, right? Not sure though. If it's legit to backport then I'd be happy to do so. |
|
Alright, no big deal. |
No description provided.