Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict special * methods for Bool, which tend to cause ambiguities #23433

Merged
merged 1 commit into from
Aug 28, 2017
Merged

restrict special * methods for Bool, which tend to cause ambiguities #23433

merged 1 commit into from
Aug 28, 2017

Conversation

JeffBezanson
Copy link
Member

These methods seem unnecessary to me; let's see if the test suite agrees.

part of #19168

@rfourquet rfourquet mentioned this pull request Aug 25, 2017
Open
@JeffBezanson
Copy link
Member Author

Ok, that didn't quite work, but it might work to restrict the special Bool methods to AbstractFloat, since the special behavior seems relevant only to floats. That will avoid ambiguities for new Number types that aren't AbstractFloats, which I suspect is the common case.

@JeffBezanson JeffBezanson changed the title remove special * methods for Bool, which tend to cause ambiguities restrict special * methods for Bool, which tend to cause ambiguities Aug 25, 2017
@JeffBezanson
Copy link
Member Author

Ok, that seems to work!

@JeffBezanson JeffBezanson merged commit 05037f5 into master Aug 28, 2017
@JeffBezanson JeffBezanson deleted the jb/boolmul branch August 28, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JeffBezanson