-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the method name to get library versions #23323
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ function version() | |
minor = Ref{Cint}(0) | ||
patch = Ref{Cint}(0) | ||
ccall((:git_libgit2_version, :libgit2), Void, | ||
(Ptr{Cint}, Ptr{Cint}, Ptr{Cint}), major, minor, patch) | ||
(Ref{Cint}, Ref{Cint}, Ref{Cint}), major, minor, patch) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated? Perhaps better in a separate pull request as such? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps, but since this is related to |
||
return VersionNumber(major[], minor[], patch[]) | ||
end | ||
const VERSION = version() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to give the same behavior as the previous function this deprecation should return a tuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true (anyone mind fixing this? I don't have time to do it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best way to fix this is to leave
laver
as it was before this change and just addversion
since, generally, our LAPACK wrappers are pretty thin and don't add much Julia abstraction on top of LAPACK.