-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate vectorized methods hiding in Dates #23207
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4010cce
Deprecate vectorized DateTime methods in favor of compact broadcast s…
Sacha0 62c3b22
Deprecate vectorized Date methods in favor of compact broadcast syntax.
Sacha0 fff9ff7
Deprecate vectorized Dates.format methods in favor of compact broadca…
Sacha0 fd25bfe
Change a few Dates tests to use the dateformat string macro.
Sacha0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -323,15 +323,14 @@ f = "ymd" | |
dr = ["2000-01-01", "2000-01-02", "2000-01-03", "2000-01-04", "2000-01-05", | ||
"2000-01-06", "2000-01-07", "2000-01-08", "2000-01-09", "2000-01-10"] | ||
dr2 = [Dates.Date(2000) : Dates.Date(2000, 1, 10);] | ||
@test Dates.Date(dr) == dr2 | ||
@test Dates.Date(dr, "yyyy-mm-dd") == dr2 | ||
@test Dates.Date.(dr) == dr2 | ||
@test Dates.Date.(dr, "yyyy-mm-dd") == dr2 | ||
@test Dates.DateTime.(dr) == Dates.DateTime.(dr2) | ||
@test Dates.DateTime(dr, "yyyy-mm-dd") == Dates.DateTime.(dr2) | ||
@test Dates.DateTime.(dr, "yyyy-mm-dd") == Dates.DateTime.(dr2) | ||
|
||
@test Dates.format(dr2) == dr | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could this test have been kept but with a dot, or is there no 1-arg |
||
@test Dates.format(dr2, "yyyy-mm-dd") == dr | ||
@test Dates.format.(dr2, "yyyy-mm-dd") == dr | ||
|
||
@test typeof(Dates.Date(dr)) == Array{Date, 1} | ||
@test typeof(Dates.Date.(dr)) == Array{Date, 1} | ||
|
||
# Issue 13 | ||
t = Dates.DateTime(1, 1, 1, 14, 51, 0, 118) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests will be more performant if we change this to use the
dateformat
string macro.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed these
Date
andDateTime
tests to use thedateformat
string macro. Thanks! :)