Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename select* functions to partialsort* and various related fixes #23051

Merged
merged 3 commits into from
Aug 27, 2017
Merged

Rename select* functions to partialsort* and various related fixes #23051

merged 3 commits into from
Aug 27, 2017
+84 −64

Commits on Aug 27, 2017

  1. Rename select* functions to partialsort* 

    The new name is more explicit, more consistent with sort and with one of the
most commonly used names for this operation (from the C++ stdlib). It also
does not conflict with other meanings e.g. for POSIX sockets and SQL.
    @nalimilan
    nalimilan committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    3588102 View commit details
    Browse the repository at this point in the history

  2. Make partialsort!() and partialsortperm!() return a view rather than … 

    …a copy

Returning a copy (partially) defeats the purpose of these functions, which is
to avoid allocations.
    @nalimilan
    nalimilan committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    8150f66 View commit details
    Browse the repository at this point in the history

  3. Fix docstrings for partialsortperm() and partialsortperm!() 

    partialsort(x, k::Integer), partialsortperm(x, k::Integer) and partialsortperm!(x, k::Integer)
all return a single value. Also add missing backticks.
    @nalimilan
    nalimilan committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    7a54a2f View commit details
    Browse the repository at this point in the history