Move things out of helpDB, add some xrefs #22889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Jul 20, 2017
tkelman
reviewed
Jul 20, 2017
base/show.jl
Outdated
| @@ -1757,6 +1762,18 @@ function showarray(io::IO, X::AbstractArray, repr::Bool = true; header = true) | |||
| end | |||
| end | |||
|
|
|||
| """ | |||
| showcompact(io::IO=STDOUT, x) | |||
There was a problem hiding this comment.
list as two separate signatures, since optional argument syntax only works for trailing arguments
There was a problem hiding this comment.
Done, and make docs passed locally.
fredrikekre
reviewed
Jul 20, 2017
base/error.jl
Outdated
| assert(cond) | ||
|
|
||
| Throw an [`AssertionError`](@ref) if `cond` is `false`. | ||
| Also available as the macro `@assert expr`. |
There was a problem hiding this comment.
While you are at it, perhaps change to Also available as the macro [`@assert`](@ref).?
There was a problem hiding this comment.
I'm kind of busy rn, if you want to edit the PR to change this (it's a good idea) go wild :)
There was a problem hiding this comment.
Nevermind! Got it, and make docs passes locally.
fredrikekre
approved these changes
Jul 21, 2017
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
* Move things out of helpDB, add some xrefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.