Move a doc out, add doctests to some things #22860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jul 18, 2017
| ERROR: BoundsError: attempt to access 7-element Array{Float64,1} at index [8] | ||
| Stacktrace: | ||
| [1] getindex(::Array{Float64,1}, ::Int64) at ./array.jl:586 | ||
|
|
There was a problem hiding this comment.
maybe add the [...] here to make it clear there's truncated extra content?
There was a problem hiding this comment.
I copy-pasted this right from the REPL, there was no extra content?
There was a problem hiding this comment.
oh the rare shallow stacktrace. repl filtered out exactly what it should've. when run as a doctest there's no complaints about the stacktrace being longer?
There was a problem hiding this comment.
I'll check just to make sure
There was a problem hiding this comment.
Yep! Passed locally for me.
tkelman
approved these changes
Jul 18, 2017
|
Is that 64 bit linux fail my fault? |
|
Bumpity bump |
|
I've been seeing that failure all over, not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the wording on
BoundsErrora little to make it clear that the index is the problem.