Added some information about bitstype in doc #16242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was really confused when attempting to use SharedArrays the first time because of this minor distinction between Types and Immutables which are effectively structs.
Skylion007
changed the title
| @@ -562,6 +562,10 @@ arrays, a shared array is accessible only from those participating | |||
| workers specified by the ``pids`` named argument (and the creating | |||
| process too, if it is on the same host). | |||
|
|
|||
| Note: If you want to store a Type like object, it must be immutable to count | |||
| as a [bitstype](http://docs.julialang.org/en/release-0.4/manual/types/). | |||
There was a problem hiding this comment.
The document is wrong here, it should be isbits not bitstype. Also, I believe you are using the markdown syntax instead of rst cross reference and you are linking the 0.4 doc here.
There was a problem hiding this comment.
@Skylion007, to clarify, the wording should be something along the lines of Note: only objects where "isbits(obj) == true" are supported. Then link to docs.julialang.org/en/latest/... instead of release-0.4. We can the backport the docs change to 0.4.
|
Ouch - shouldn't have closed and reopened. This is a nice update. I'll get it in and close after #35650 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was really confused when attempting to use SharedArrays the first time because of this minor distinction between Types and Immutables which are effectively structs.