"Failed to revise `base/Base.jl`: UndefVarError: `strcat` not defined in `Main`

[fingolfin]

Maybe this is a red herring, but I've seen in this CI log: https://buildkite.com/julialang/julia-master/builds/47232#0196a6ba-0b83-4658-8ae3-4a766a8efb90

┌ Error: Failed to revise /cache/build/builder-amdci5-2/julialang/julia-master/base/Base.jl
  | │   exception =
  | │    UndefVarError: `strcat` not defined in `Main`
  | │    Suggestion: check for spelling errors or missing imports.
  | │    Stacktrace:
  | │     [1] top-level scope
  | │       @ /cache/build/builder-amdci5-2/julialang/julia-master/base/Base.jl:19
  | │    Revise evaluation error at /cache/build/builder-amdci5-2/julialang/julia-master/base/Base.jl:19
  | │
  | └ @ Revise ~/.julia/packages/Revise/Iwohz/src/packagedef.jl:776
 

The offending code in base/Base.jl:

include(strcat(BUILDROOT, "build_h.jl"))     # include($BUILDROOT/base/build_h.jl)
include(strcat(BUILDROOT, "version_git.jl")) # include($BUILDROOT/base/version_git.jl)

It looks as is strcat used to be defined right before this but was moved to base/Base_compiler.jl in PR #56409 by @Keno

[Keno]

This is some sort of intermittent issue in the Revise.jl tests. Probably file it there? Since it's not persistent, I don't think it's a base issue.

[Keno]

I'm seeing this locally now also, but it's inconsistent. Let me see if I can figure out what's actually going on.

[vtjnash]

I just fixed this on master