Skip to content

Incorrect ccall signature for _include_from_serialized #57459

@vtjnash

Description

@vtjnash

Bug appears to have been introduced by #56499. I don't know why this changed the ccall type in the middle of the other changes, but it introduced unsoundness here and triggers observable errors in CI:

      From worker 2:	ERROR: TypeError: in _svec_ref, expected Core.SimpleVector, got a value of type ErrorException
2025-02-17 17:49:27 EST	      From worker 2:	Stacktrace:
2025-02-17 17:49:27 EST	      From worker 2:	  [1] getindex
2025-02-17 17:49:27 EST	      From worker 2:	    @ ./essentials.jl:933 [inlined]
2025-02-17 17:49:27 EST	      From worker 2:	  [2] _include_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String, depmods::Vector{Any}, ignore_native::Nothing; register::Bool)
2025-02-17 17:49:27 EST	      From worker 2:	    @ Base ./loading.jl:1294
2025-02-17 17:49:27 EST	      From worker 2:	  [3] _include_from_serialized (repeats 2 times)
2025-02-17 17:49:27 EST	      From worker 2:	    @ ./loading.jl:1246 [inlined]
2025-02-17 17:49:27 EST	      From worker 2:	  [4] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt128, stalecheck::Bool; reasons::Dict{String, Int64}, DEPOT_PATH::Vector{String})

https://buildkite.com/julialang/julia-master/builds/44900#019515d0-b7af-488d-bcb4-ae04e63e8459

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciContinuous integrationregression 1.12Regression in the 1.12 release

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions