Skip to content

regression in thread-safety correctness of detecting compilation finished #53432

Closed
@vtjnash

Description

@vtjnash

The ci_has_abi uses monotonic loads, so #53219 introduced a data-race here. I think it needs an :acquire on one or move of these to fix that, so that it must observe this being set. And also needs to switch the order of the checks, so that it correctly pairs with the release store.

Originally posted by @vtjnash in #53219 (comment)

Posting as an issue since the PR is already merged, so this doesn't get lost

Metadata

Metadata

Assignees

No one assigned

    Labels

    compiler:inferenceType inferencemultithreadingBase.Threads and related functionalityregressionRegression in behavior compared to a previous version

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions