Out of tree builds fails to copy base julia files

[musm]

Running the julia installer after running make -C outdir binary-dist from cygwin for a windows build.

share/julia/base only includes the files:

[musm]

This is kind of a mystery to me, nothing in the Makefile has changed that touched the lines that copy the files over, unless I'm reading things wrong.

[musm]

It looks like the junction to base is incorrect?

cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libssp-0.dll /cygdrive/c/Users/Mus/work/julia/build/usr/bin
cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libssp-0.dll /cygdrive/c/Users/Mus/work/julia/build/usr/tools
Junction created for C:\Users\Mus\work\julia\build\usr\share\julia\test <<===>> C:\Users\Mus\work\julia\source\test

Junction created for C:\Users\Mus\work\julia\build\usr\share\julia\base <<===>> base

cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libwinpthread-1.dll /cygdrive/c/Users/Mus/work/julia/build/usr/bin
cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libwinpthread-1.dll /cygdrive/c/Users/Mus/work/julia/build/usr/tools
cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libatomic-1.dll /cygdrive/c/Users/Mus/work/julia/build/usr/bin
cp /usr/x86_64-w64-mingw32/sys-root/mingw/bin/../bin//libatomic-1.dll /cygdrive/c/Users/Mus/work/julia/build/usr/tools
/cygdrive/c/Users/Mus/work/julia/source/contrib/install.sh 755 /cygdrive/c/Users/Mus/work/julia/source/contrib/julia-config.jl /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/
Creating usr/etc/julia/startup.jl
Copying in usr/share/man/man1/julia.1
make[1]: Entering directory '/cygdrive/c/Users/Mus/work/julia/build/stdlib'
make[1]: Entering directory '/cygdrive/c/Users/Mus/work/julia/build/deps'
Junction created for C:\Users\Mus\work\julia\build\usr\share\julia\stdlib\v1.2\Dates <<===>> C:\Users\Mus\work\julia\source\stdlib\Dates

[musm]

I just nuked all my source and build folders and tried this again. And indeed the bug reproducible.

the OOT directories' base folder is empty and nothing gets copied there other than the files with constants.

[musm]

Is anyone else able to reproduce this? I'd love to get some other people to see if they are also encountering this, since it's an important bug if reproducible.

[musm]

Confirmed that this only happens with OOT builds

[StefanKarpinski]

Took me a minute to figure out that "OOT" = "out of tree"; spelling it out for others 😺

[musm]

👍 Thanks, yes I should've avoided the abbreviation in the issue title

[musm]

Ok I've identified what's causing this failure

cmd /C mklink /J `cygpath -w /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/stdlib/v1.2/SuiteSparse` `cygpath -w /cygdrive/c/Users/Mus/work/julia/source/stdlib/SuiteSparse`
cmd /C mklink /J `cygpath -w /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/stdlib/v1.2/Test` `cygpath -w /cygdrive/c/Users/Mus/work/julia/source/stdlib/Test`
cmd /C mklink /J `cygpath -w /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/stdlib/v1.2/Unicode` `cygpath -w /cygdrive/c/Users/Mus/work/julia/source/stdlib/Unicode`
cmd /C mklink /J `cygpath -w /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/stdlib/v1.2/UUIDs` `cygpath -w /cygdrive/c/Users/Mus/work/julia/source/stdlib/UUIDs`
make[1]: Leaving directory '/cygdrive/c/Users/Mus/work/julia/build/stdlib'
cmd /C mklink /J `cygpath -w /cygdrive/c/Users/Mus/work/julia/build/usr/share/julia/base` `cygpath -w base`

As you can see in the last line the absolute path of base is NOT passed during the symlink process.

Ok I think I see the source of the bug!