Closed
Description
Since it seems that both Base and some packages use the horrifically named @test_approx_eq_modphase
macro, perhaps it would be useful for a modphase
keyword to be introduced for the isapprox
function at which point @test_approx_eq_modphase a b
could be cleanly deprecated in favor of @test a ≈ b modphase=true
instead of simply deleting the macro or copy-pasta-ing everywhere. I, however, do not feel that I have the expertise to correctly implement such a keyword argument for the function, so if someone who understands what this macro is for could implement it, that would be greatly appreciated. cc: @andreasnoack, @jiahao, @stevengj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment