use map!

JuliaLang · Jan 14, 2022 · f999b7a · f999b7a
1 parent 2cf728a
commit f999b7a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/stdlib/Profile/src/Profile.jl b/stdlib/Profile/src/Profile.jl
@@ -351,15 +351,15 @@ end
 function getdict!(dict::LineInfoDict, data::Vector{UInt})
     # we don't want metadata here as we're just looking up ips
     unique_data_itr = Iterators.unique(has_meta(data) ? strip_meta(data) : data)
-    foreach(ip -> dict[UInt64(ip)] = StackFrame[], unique_data_itr)
+    foreach(ip -> dict[UInt64(ip)] = StackFrame[], unique_data_itr) # preallocate
     @sync for ip in unique_data_itr
         Threads.@spawn begin
             st = lookup(convert(Ptr{Cvoid}, ip))
             # To correct line numbers for moving code, put it in the form expected by
             # Base.update_stackframes_callback[]
             stn = map(x->(x, 1), st)
             try Base.invokelatest(Base.update_stackframes_callback[], stn) catch end
-            dict[UInt64(ip)] = map(first, stn)
+            map!(first, dict[UInt64(ip)], stn)
         end
     end
     return dict