allow chop to take an empty string (#31312)

(cherry picked from commit 023c8e4)
JuliaLang · Feb 20, 2020 · 69f4dbd · 69f4dbd
1 parent a9718f9
commit 69f4dbd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/base/strings/util.jl b/base/strings/util.jl
@@ -96,6 +96,9 @@ julia> chop(a, head = 5, tail = 5)
 ```
 """
 function chop(s::AbstractString; head::Integer = 0, tail::Integer = 1)
+    if isempty(s)
+        return SubString(s)
+    end
     SubString(s, nextind(s, firstindex(s), head), prevind(s, lastindex(s), tail))
 end
 

diff --git a/test/strings/util.jl b/test/strings/util.jl
@@ -301,6 +301,7 @@ end
     @test chomp("foo\r\n") == "foo"
     @test chomp("fo∀\r\n") == "fo∀"
     @test chomp("fo∀") == "fo∀"
+    @test chop("") == ""
     @test chop("fooε") == "foo"
     @test chop("foεo") == "foε"
     @test chop("∃∃∃∃") == "∃∃∃"