-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix O(n^2)
length
calls in compact-ir lowering step (#50756)
This can be a problem for very long function bodies.
- Loading branch information
1 parent
33e3d9f
commit 3c64bc3
Showing
1 changed file
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to try out some Nanosoldier.jl stuff here, sorry for the noise.
@nanosoldier
runtests(["JSON", "Crayons"], vs = "@f00957bf6f33f589577dbff903e0dd64b4a6b152")
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package evaluation job you requested has completed - no new issues were detected.
The full report is available.
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LilithHafner That output doesn't look great; both the
0000-12-03 to 0001-01-01
and the Markdown rendering. How did you render the output shown in the PR?I'm going to revert the change for now, as I'll be AFK for a couple of days.
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanosoldier
runtests(["JSON", "Crayons"], vs = "@f00957bf6f33f589577dbff903e0dd64b4a6b152")
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package evaluation job you requested has completed - no new issues were detected.
The full report is available.
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross reference JuliaCI/Nanosoldier.jl#170 / JuliaCI/Nanosoldier.jl#172
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanosoldier
runbenchmarks(ALL, isdaily = true)
3c64bc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.