interpret Expr(:isdefined, ::QuoteNode) correctly

discovered in JuliaDebug/JuliaInterpreter.jl#477
JuliaLang · Apr 22, 2021 · 3c4fa1e · 3c4fa1e
1 parent 50400fb
commit 3c4fa1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/interpreter.c b/src/interpreter.c
@@ -236,7 +236,8 @@ static jl_value_t *eval_value(jl_value_t *e, interpreter_state *s)
             }
         }
         else {
-            assert(0 && "malformed isdefined expression");
+            // QuoteNode or other implicitly quoted object
+            defined = 1;
         }
         return defined ? jl_true : jl_false;
     }

diff --git a/test/interpreter.jl b/test/interpreter.jl
@@ -30,3 +30,11 @@ let p = Pipe(),
     wait(proc)
     close(p)
 end
+
+# interpreting Expr(:isdefined, ::QuoteNode)
+let code = """
+           @generated f() = Expr(:isdefined, QuoteNode(Float64))
+           f()
+           """
+    @test read(`$(Base.julia_cmd()) --startup-file=no --compile=min -e $code`, String) == "true"
+end