Skip to content

Fix lack of color in CI and don't warn about loaded packages in test Pkg.precompile. #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2025
Merged

Fix lack of color in CI and don't warn about loaded packages in test Pkg.precompile. #4316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b40ecef
debug #4158
IanButterworth Jul 12, 2025
1f5c625
Update API.jl
IanButterworth Jul 12, 2025
6f14833
reduce to fix
IanButterworth Jul 12, 2025
3c068e3
also fix not warning about loaded packages
IanButterworth Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/API.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,10 +1172,12 @@ function precompile(ctx::Context, pkgs::Vector{PackageSpec}; internal_call::Bool
end

io = ctx.io
if io isa IOContext{IO}
if io isa IOContext{IO} && !isa(io.io, Base.PipeEndpoint)
# precompile does quite a bit of output and using the IOContext{IO} can cause
# some slowdowns, the important part here is to not specialize the whole
# precompile function on the io
# precompile function on the io.
# But don't unwrap the IOContext if it is a PipeEndpoint, as that would
# cause the output to lose color.
io = io.io
end

Expand Down
4 changes: 3 additions & 1 deletion src/Operations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2476,7 +2476,9 @@ function test(ctx::Context, pkgs::Vector{PackageSpec};

if should_autoprecompile()
cacheflags = Base.CacheFlags(parse(UInt8, read(`$(Base.julia_cmd()) $(flags) --eval 'show(ccall(:jl_cache_flags, UInt8, ()))'`, String)))
Pkg.precompile(; io=ctx.io, configs = flags => cacheflags)
# Don't warn about already loaded packages, since we are going to run tests in a new
# subprocess anyway.
Pkg.precompile(; io=ctx.io, warn_loaded = false, configs = flags => cacheflags)
end

printpkgstyle(ctx.io, :Testing, "Running tests...")
Expand Down