Ensure precompilation when testing runs without threads on Julia 1.11 #4140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemann
force-pushed
the
feature/1.11_test_precompile_threads
branch
4 times, most recently
from
13607ff to
6c64500
Compare
|
@IanButterworth I've updated this one by cherry-picking #4141 |
|
Note the target branch ( |
|
@KristofferC This PR is related to #4141 just merged into release-1.11 with #4204. Should (and can) this be included for the next 1.11? |
|
Probably yes, there was no backport label on this so I didn't see it. Needs a rebase though. |
Fixes JuliaLang/julia#56458 Precompilation with threads is not supported: JuliaLang/julia#53572 (comment) Ensures that tests run with threads, both when calling `julia --project --threads=auto --eval 'using Pkg; Pkg.test()'`, and when calling `julia --project --eval 'using Pkg; Pkg.test(; julia_args = ["--threads=auto"])'`.
stemann
force-pushed
the
feature/1.11_test_precompile_threads
branch
from
0e8dd5b to
2e87b53
Compare
|
Rebase done |
…l position to reduce diff wrt. `master`
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/julia#56458
Precompilation with threads is not supported: JuliaLang/julia#53572 (comment)
Ensures that tests run with threads, both when calling
julia --project --threads=auto --eval 'using Pkg; Pkg.test()', and when callingjulia --project --eval 'using Pkg; Pkg.test(; julia_args = ["--threads=auto"])'.