Report failures to download artifacts as failures #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an artifact that failed to download might print like this:
```
(proj) pkg> instantiate
Downloaded artifact: Example
Downloaded artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
With this change, that becomes:
```
(proj) pkg> instantiate
Failure artifact: Example
Failure artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
IanButterworth
pushed a commit
that referenced
this pull request
Apr 11, 2024
Previously, an artifact that failed to download might print like this:
```
(proj) pkg> instantiate
Downloaded artifact: Example
Downloaded artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
With this change, that becomes:
```
(proj) pkg> instantiate
Failure artifact: Example
Failure artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
(cherry picked from commit 8cc835c)
6 tasks
KristofferC
pushed a commit
that referenced
this pull request
Apr 25, 2024
Previously, an artifact that failed to download might print like this:
```
(proj) pkg> instantiate
Downloaded artifact: Example
Downloaded artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
With this change, that becomes:
```
(proj) pkg> instantiate
Failure artifact: Example
Failure artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
(cherry picked from commit 8cc835c)
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2024
Previously, an artifact that failed to download might print like this:
```
(proj) pkg> instantiate
Downloaded artifact: Example
Downloaded artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
With this change, that becomes:
```
(proj) pkg> instantiate
Failure artifact: Example
Failure artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
KristofferC
pushed a commit
that referenced
this pull request
Jul 5, 2024
Previously, an artifact that failed to download might print like this:
```
(proj) pkg> instantiate
Downloaded artifact: Example
Downloaded artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
With this change, that becomes:
```
(proj) pkg> instantiate
Failure artifact: Example
Failure artifact: Example
ERROR: Unable to automatically download/install artifact 'Example' from sources listed in ...
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an artifact that failed to download might print like this:
With this change, that becomes: