Skip to content

Fix extended missing package add prompt #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Fix extended missing package add prompt #3082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/REPLMode/REPLMode.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ function try_prompt_pkg_add(pkgs::Vector{Symbol})
editable_envs = filter(v -> v != "@stdlib", LOAD_PATH)
option_list = String[]
keybindings = Char[]
shown_envs = String[]
# We use digits 1-9 as keybindings in the env selection menu
# That's why we can display at most 9 items in the menu
for i in 1:min(length(editable_envs), 9)
Expand All @@ -730,6 +731,7 @@ function try_prompt_pkg_add(pkgs::Vector{Symbol})
n = length(option_list) + 1
push!(option_list, "$(n): $(pathrepr(expanded_env)) ($(env))")
push!(keybindings, only("$n"))
push!(shown_envs, expanded_env)
end
menu = TerminalMenus.RadioMenu(option_list, keybindings=keybindings, pagesize=length(option_list))
print(ctx.io, "\e[1A\e[1G\e[0J") # go up one line, to the start, and clear it
Expand All @@ -744,7 +746,7 @@ function try_prompt_pkg_add(pkgs::Vector{Symbol})
rethrow()
end
choice == -1 && return false
API.activate(envs[choice]) do
API.activate(shown_envs[choice]) do
API.add(string.(available_pkgs))
end
elseif (lower_resp in ["n"])
Expand Down